Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/dev17.3 to main-vs-deps #60431

Merged
merged 479 commits into from
Mar 31, 2022
Merged

Merge release/dev17.3 to main-vs-deps #60431

merged 479 commits into from
Mar 31, 2022

Conversation

allisonchou
Copy link
Contributor

Ideally #60429 should merge before this does.
After this, we should be able to delete release/dev17.3

CyrusNajmabadi and others added 30 commits March 3, 2022 22:51
Use the same codepath for computing light-bulb actions to determine if hte lightbulb shoudl appear at all.
Break out embedded language classification entirely from normal classification
Push the two-step navigation system further through roslyn.
Add new feature to fix invalid constraints.
Port 'Top Level Statements' code style PR to 17.3
@JoeRobich
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@RikkiGibson
Copy link
Contributor

A VB stack depth test is failing here. Maybe because we recently added a fix to actually run 64-bit tests in 64-bit mode? cc @jaredpar

Expected:
Diagnostic(ERRID.ERR_TooLongOrComplexExpression, "a").WithLocation(7, 16),
Diagnostic(ERRID.ERR_TooLongOrComplexExpression, "a").WithLocation(7, 16),
Diagnostic(ERRID.ERR_TooLongOrComplexExpression, "a").WithLocation(7, 16)
Actual:
Diagnostic(ERRID.ERR_TooLongOrComplexExpression, "a").WithLocation(7, 16),
Diagnostic(ERRID.ERR_TooLongOrComplexExpression, "a").WithLocation(7, 16)
Diff:
Diagnostic(ERRID.ERR_TooLongOrComplexExpression, "a").WithLocation(7, 16)
Diagnostic(ERRID.ERR_TooLongOrComplexExpression, "a").WithLocation(7, 16)
-->     Diagnostic(ERRID.ERR_TooLongOrComplexExpression, "a").WithLocation(7, 16)
Expected: True
Actual:   False

I'm assuming the plan is to disable the test and add a tracking issue?

@JoeRobich JoeRobich merged commit 3c16fd2 into main-vs-deps Mar 31, 2022
@ghost ghost added this to the Next milestone Mar 31, 2022
@JoeRobich
Copy link
Member

Merging as Spanish queue is being fixed in the main to main-vs-deps merge PR.

@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants