Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused abstract property CodeFixCategory #60536

Merged
merged 4 commits into from
Apr 4, 2022
Merged

Remove unused abstract property CodeFixCategory #60536

merged 4 commits into from
Apr 4, 2022

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Apr 2, 2022 •
edited
Loading

The only single read for this property is in IsForCodeQualityImprovement, which is unused.

For history, this was used for info bar to suggest installing FxCop #37034. This is no longer needed.

@Youssef1313 Youssef1313 requested review from a team as code owners April 2, 2022 15:47
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Apr 2, 2022
@Youssef1313
Copy link
Member Author

@mavasani @CyrusNajmabadi

@mavasani mavasani merged commit 30ed50e into dotnet:main Apr 4, 2022
@ghost ghost added this to the Next milestone Apr 4, 2022
@Youssef1313 Youssef1313 deleted the remove-fix-category branch April 4, 2022 06:10
@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavasani mavasani mavasani approved these changes

@Therzok Therzok Therzok approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
17.3.P1
Development

Successfully merging this pull request may close these issues.
4 participants
@Youssef1313 @Therzok @mavasani @dibarbet