Pull feature-specific APIs out of ISyntaxFacts #60636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Apr 7, 2022
| // Violation. This should return a SyntaxList | ||
| IReadOnlyList<SyntaxNode> GetExecutableBlockStatements(SyntaxNode? node); | ||
| // Violation. This is a feature level API. | ||
| SyntaxNode? FindInnermostCommonExecutableBlock(IEnumerable<SyntaxNode> nodes); |
There was a problem hiding this comment.
ISyntaxFacts defines (in a comment on the type) the sorts of operations it is supposed to provide. Specifically, it only abstracts over common syntax constructs that both VB and C# have (e.g. an 'if statement'). It is not intended to make many constructs from the same language appear similar. For that, we want specific other services/features that are based around that concept and are clear on what their particular semantics are.
mavasani
approved these changes
Apr 8, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.