Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the TemporaryWorkspace entirely from the RemoteWorkspace code. #60638

Merged

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Apr 7, 2022

This type existed for a couple of reasons that no longer are valid anymore.

First, we used to have a key/value persistence store that features assumed they could write/read from in isolation. This would break in OOP if multiple calls were made to the same workspace and the features wrote/read from teh same keys. different features would see the results of other calls while they were in flight. In particular, this broke Diagnostics, which would persist out data and assume it could read it back without anything else being involved. However, a while back we both removed persistence of data from Diagnostics, and we also removed teh general key/value store entirely (now we only have a checksummed key/value store, where all clients must only use it as a speedup/cache, and cannot assume anything beyond that if something exists with teh same checksum, then it has the same data).

Second, we would share an options service across all calls, meaning if one call came in and mutated options, then that would impact other calls at the same time that wanted different options. All our work to make it so that oop features pass along the options they want as data makes this now unnecessary.

@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review April 8, 2022 17:19
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner April 8, 2022 17:19
@CyrusNajmabadi CyrusNajmabadi requested a review from tmat April 8, 2022 17:19
Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 2a5ae36 into dotnet:main Apr 8, 2022
@ghost ghost added this to the Next milestone Apr 8, 2022
@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the removeTemporaryWorkspace branch May 3, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants