Remove the TemporaryWorkspace entirely from the RemoteWorkspace code. #60638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type existed for a couple of reasons that no longer are valid anymore.
First, we used to have a key/value persistence store that features assumed they could write/read from in isolation. This would break in OOP if multiple calls were made to the same workspace and the features wrote/read from teh same keys. different features would see the results of other calls while they were in flight. In particular, this broke Diagnostics, which would persist out data and assume it could read it back without anything else being involved. However, a while back we both removed persistence of data from Diagnostics, and we also removed teh general key/value store entirely (now we only have a checksummed key/value store, where all clients must only use it as a speedup/cache, and cannot assume anything beyond that if something exists with teh same checksum, then it has the same data).
Second, we would share an options service across all calls, meaning if one call came in and mutated options, then that would impact other calls at the same time that wanted different options. All our work to make it so that oop features pass along the options they want as data makes this now unnecessary.