Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to features/required-members #60674

Merged

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from main into features/required-members.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/main-to-features/required-members
git reset --hard upstream/features/required-members
git merge upstream/main
# Fix merge conflicts
git commit
git push upstream merges/main-to-features/required-members --force

CyrusNajmabadi and others added 30 commits April 1, 2022 09:47
Pause taggers when they are not visible.
…se/dev17.2

Merge release/dev17.1 to release/dev17.2
Change project-cone-sync to not dump projects outside of the cone.
@dotnet-bot dotnet-bot requested review from a team as code owners April 10, 2022 00:02
@dotnet-bot dotnet-bot added Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch. labels Apr 10, 2022
@dotnet-bot
Copy link
Collaborator Author

⚠ This PR has merge conflicts. @333fred

ghost
ghost previously approved these changes Apr 10, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

tmat and others added 8 commits April 10, 2022 02:09
Delay starting the work to scan for todo-items
* Remove duplicate package references

* Delete additional Tools.props
…ures/required-members

* upstream/main: (652 commits)
  Remove duplicate package references (#60658)
  Formatting and code generation options (#60127)
  Trim unnessasary leading lines when removing usings (#60672)
  Pass options to FixAllAsync, simplify CodeAction registration (#60665)
  Fallout
  Lint
  Restore CodeStyle test projects
  Update struct field definite assignment tests
  Global indentation options - take 2 (#60565)
  Run continuation to dispose of cancellation token source (#60653)
  Fixup
  Update tests
  Cleanup
  Cleanup
  move properties
  Delay starting the work to scan for todo-items
  Simplify
  Clean up syntax context
  Clean up syntax context
  Clean up syntax context
  ...
@333fred 333fred disabled auto-merge April 11, 2022 21:39
@333fred
Copy link
Member

333fred commented Apr 11, 2022

@RikkiGibson or @jcouv please review the last commit, 32bb9f6.

@333fred 333fred dismissed ghost ’s stale review April 11, 2022 21:40

Need a real review.

@333fred 333fred enabled auto-merge April 11, 2022 21:40
@333fred 333fred disabled auto-merge April 11, 2022 23:16
@333fred
Copy link
Member

333fred commented Apr 11, 2022

Forcing past External Access test failures, that isn't touched in this branch.

@333fred 333fred merged commit b0798f4 into features/required-members Apr 11, 2022
@333fred 333fred deleted the merges/main-to-features/required-members branch April 11, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.