Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failures in features/semi-auto-props #61344

Merged
merged 3 commits into from
May 16, 2022
Merged

Fix test failures in features/semi-auto-props #61344

merged 3 commits into from
May 16, 2022

Conversation

Youssef1313
Copy link
Member

The merge from main included a change that removed extra unused diagnostic arguments. But CI run in the merge PR didn't include these tests.

@Youssef1313 Youssef1313 requested a review from a team as a code owner May 16, 2022 13:35
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label May 16, 2022
@Youssef1313 Youssef1313 mentioned this pull request May 16, 2022
Merged
@AlekseyTs
Copy link
Contributor

@Youssef1313 It looks like some tests are still failing.

@AlekseyTs
Copy link
Contributor

Done with review pass (commit 1)

AlekseyTs
AlekseyTs approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 3)

@AlekseyTs AlekseyTs merged commit d04d096 into dotnet:features/semi-auto-props May 16, 2022
@Youssef1313 Youssef1313 deleted the patch-9 branch May 16, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees
No one assigned
Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Youssef1313 @AlekseyTs