Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/dev17.3 to release/dev17.4 #62961

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from release/dev17.3 into release/dev17.4.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/release/dev17.3-to-release/dev17.4
git reset --hard upstream/release/dev17.4
git merge upstream/release/dev17.3
# Fix merge conflicts
git commit
git push upstream merges/release/dev17.3-to-release/dev17.4 --force

…hanged (#62849)

* HasChangesAsync should return false if the document content did not changed

* Comment

* Test source generated docs

* Fix rebase

* Include PopulateChangedAndAddedDocumentsAsync in test
@dotnet-bot dotnet-bot requested a review from a team as a code owner July 27, 2022 00:01
@dotnet-bot dotnet-bot added Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch. labels Jul 27, 2022
@dotnet-bot
Copy link
Collaborator Author

⚠ This PR has merge conflicts. @allisonchou

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@JoeRobich JoeRobich removed the Merge Conflicts There are merge conflicts with the base branch. label Jul 27, 2022
@JoeRobich JoeRobich disabled auto-merge July 29, 2022 03:30
@JoeRobich JoeRobich merged commit 5de5410 into release/dev17.4 Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants