Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ForAttributeWithMetadataName to use an explicit stack when recursing #64322

Merged
merged 4 commits into from
Sep 29, 2022
Merged

Change ForAttributeWithMetadataName to use an explicit stack when recursing #64322

merged 4 commits into from
Sep 29, 2022

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #64225

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner September 27, 2022 19:09
333fred
333fred approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor style comment.

...ilers/Core/Portable/SourceGeneration/Nodes/SyntaxValueProvider_ForAttributeWithSimpleName.cs Outdated Show resolved Hide resolved
@CyrusNajmabadi
Copy link
Member Author

@dotnet/roslyn-compiler @jaredpar @chsienki for another set of eyes on this incremental generator PR. Thanks!

@CyrusNajmabadi
Copy link
Member Author

https://github.com/orgs/dotnet/teams/roslyn-compiler @jaredpar @chsienki for another set of eyes on this incremental generator PR. Thanks!

@jaredpar
Copy link
Member

All @CyrusNajmabadi changes need GitHub to default to clicking the "hide whitespace changes" button ;)

@CyrusNajmabadi CyrusNajmabadi merged commit 0158ff5 into dotnet:main Sep 29, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the fawmnOverflow branch September 29, 2022 18:41
@ghost ghost added this to the Next milestone Sep 29, 2022
@CyrusNajmabadi
Copy link
Member Author

Agreed :)

@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Oct 3, 2022
Closed
@allisonchou allisonchou mentioned this pull request Oct 11, 2022
Closed
This was referenced Oct 12, 2022
Closed
Merged
Merged
Merged
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@jaredpar jaredpar jaredpar approved these changes

Assignees
No one assigned
Labels
Area-Compilers
Projects
None yet
Milestone
17.5 P1
Development

Successfully merging this pull request may close these issues.

StackOverflowException when compiling project with large (12MB) cs file and targeting net6.0
4 participants
@CyrusNajmabadi @jaredpar @333fred @RikkiGibson