Ensure lvalue struct receivers are not copied by value by implicit Range indexer rewrite #65805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… indexer rewrite Fixes dotnet#65586.
|
@dotnet/roslyn-compiler Please review |
333fred
approved these changes
Dec 6, 2022
|
@dotnet/roslyn-compiler For the second review. |
1 similar comment
|
@dotnet/roslyn-compiler For the second review. |
AlekseyTs
changed the title
|
@dotnet/roslyn-compiler For the second review. |
cston
reviewed
Dec 8, 2022
| IL_0026: pop | ||
| IL_0027: ret | ||
| } | ||
| "); |
There was a problem hiding this comment.
Should we include VerifyIL("Shift2<T>", ...); as well here, and in GenericTypeParameterAsReceiver_ImpicitRangeIndexer_RangeExpression_Struct_Ref? #Resolved
There was a problem hiding this comment.
Should we include
VerifyIL("Shift2<T>", ...);as well here, and in ...
That method is the same as in the "Class" flavor of the test and its IL is verified there.
There was a problem hiding this comment.
Here we only need to verify its runtime behavior with an input which is a struct
cston
approved these changes
Dec 8, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65586.
Related to #63221.