Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MemberNotNull on required members in nullable analysis #65987

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Support MemberNotNull on required members in nullable analysis #65987

merged 3 commits into from
Dec 16, 2022

Conversation

333fred
Copy link
Member

@333fred 333fred commented Dec 13, 2022 •
edited
Loading

@333fred 333fred requested a review from a team as a code owner December 13, 2022 23:00
@333fred 333fred added Feature - Required Members Required properties and fields Area-Compilers and removed Area-Compilers labels Dec 13, 2022
@333fred
Copy link
Member Author

333fred commented Dec 13, 2022

@dotnet/roslyn-compiler @RikkiGibson for review.

@333fred 333fred requested a review from RikkiGibson December 13, 2022 23:06
@333fred
Copy link
Member Author

333fred commented Dec 15, 2022

@RikkiGibson @dotnet/roslyn-compiler for reviews please.

@RikkiGibson RikkiGibson self-assigned this Dec 16, 2022
@AlekseyTs
Copy link
Contributor

Done with review pass (commit 2)

AlekseyTs
AlekseyTs approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 3), assuming CI is passing.

@333fred 333fred enabled auto-merge (squash) December 16, 2022 20:15
@333fred 333fred merged commit 9c30151 into dotnet:main Dec 16, 2022
@ghost ghost added this to the Next milestone Dec 16, 2022
@333fred 333fred deleted the membernotnull-required branch December 16, 2022 22:56
@allisonchou allisonchou mentioned this pull request Dec 20, 2022
Closed
333fred added a commit to 333fred/roslyn that referenced this pull request Dec 21, 2022
@333fred
Support MemberNotNull on required members in nullable analysis (dotne…
662a437 
…t#65987)

* Support MemberNotNull on required members in nullable analysis

Fixes dotnet/csharplang#6754, dotnet#65406.

* Handle and add test for IDE-discovered scenario.

* PR feedback.
@333fred 333fred mentioned this pull request Jan 3, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.5 P3 Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

Assignees

@RikkiGibson RikkiGibson

Labels
Area-Compilers Feature - Required Members Required properties and fields
Projects
None yet
Milestone
17.5 P3
4 participants
@333fred @AlekseyTs @RikkiGibson @Cosifne