Continued analyzer assembly loading work #66612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RikkiGibson, @jcouv, @cston PTAL |
RikkiGibson
reviewed
Jan 31, 2023
src/Compilers/Core/CodeAnalysisTest/DefaultAnalyzerAssemblyLoaderTests.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Jan 31, 2023
src/Compilers/Core/CodeAnalysisTest/DefaultAnalyzerAssemblyLoaderTests.cs
Show resolved
Hide resolved
RikkiGibson
approved these changes
Jan 31, 2023
|
|
||
| #else | ||
|
|
||
| // The AsesmblyLoadTestFixture collection can't be taken advantage of on .NET Framework because |
There was a problem hiding this comment.
Suggested change
| // The AsesmblyLoadTestFixture collection can't be taken advantage of on .NET Framework because | |
| // The AssemblyLoadTestFixture collection can't be taken advantage of on .NET Framework because |
cston
approved these changes
Jan 31, 2023
jcouv
reviewed
Jan 31, 2023
src/Compilers/Core/Portable/DiagnosticAnalyzer/DefaultAnalyzerAssemblyLoader.Desktop.cs
Show resolved
Hide resolved
jcouv
approved these changes
Jan 31, 2023
jaredpar
force-pushed
the
load3
branch
2 times, most recently
from
2a6437d to
00d0082
Compare
This change responds to several concerns raised in dotnet#66492: - Collapse the `AnalyzerAssembyLoader` hierarchy by one level and move more logic into the base type. - Fix `AssemblyLoadContext` in tests to not replicate types. That means we can safely pass `ITestOutputHelper` into the custom `AssemblyLoadContext` - Further strengthen the test separation I have deliberately not changed the file names to reflect the new type names because I wanted the review process to be smooth. Once I have two sign offs for the change I will send another commit which does the following: - Rename - DefaultAnalyzerAssemblyLoaderTests.cs -> AnalyzerAssemblyLoaderTests.cs - DefaultAnalyzerAssemblyLoader.Core.cs -> AnalyzerAssemblyLoader.Core.cs - DefaultAnalyzerAssemblyLoader.Desktop.cs -> AnalyzerAssemblyLoader.Desktop.cs - DefaultAnalyzerAssemblyLoader.cs -> AnalyzerAssemblyLoader.cs - Move - `DefaultAnalyzerAssemblyLoader` into DefaultAnalyzerAssemblyLoader.cs - `InvokeUtil` to InvokeUtil.cs. As constructed every edit to this type causes Test Explorer to lose context on the theory branches. Doesn't come back until rebuild. Will be smoother editting in its own file. That should get is into the style we expect here. After that I will merge once tests are green.
This also has the added benefit that the entire .NET Core set of tests run in less than one second. Previously it close to half a second per test. This will hopefully alleviate the pain for the runtime issue we're hittnig running `AssemblyLoadContext` tests in CI. This reduces the amount of compilations on this code path which seem to be the trigger for the failure. - dotnet#66621 - dotnet/runtime#81108
Co-authored-by: Rikki Gibson <[email protected]>
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change responds to several concerns raised in #66492:
AnalyzerAssembyLoaderhierarchy by one level and move more logic into the base type.AssemblyLoadContextin tests to not replicate types. That means we can safely passITestOutputHelperinto the customAssemblyLoadContextI have deliberately not changed the file names to reflect the new type names because I wanted the review process to be smooth. Once I have two sign offs for the change I will send another commit which does the following:
DefaultAnalyzerAssemblyLoaderinto DefaultAnalyzerAssemblyLoader.csInvokeUtilto InvokeUtil.cs. As constructed every edit to this type causes Test Explorer to lose context on the theory branches. Doesn't come back until rebuild. Will be smoother editting in its own file.That should get is into the style we expect here. After that I will merge once tests are green.