Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow interface_body and enum_body to consist of just a ;. #66720

Conversation

AlekseyTs
Copy link
Contributor

@AlekseyTs
Copy link
Contributor Author

@cston, @jjonescz, @dotnet/razor-compiler Please review.

@@ -3417,7 +3417,7 @@
<Kind Name="SemicolonToken"/>
</Field>
</Node>
<Node Name="InterfaceDeclarationSyntax" Base="TypeDeclarationSyntax">
<Node Name="InterfaceDeclarationSyntax" Base="TypeDeclarationSyntax" SkipConvenienceFactories="true">
Copy link
Member

@jcouv jcouv Feb 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SkipConvenienceFactories="true"

Should we add this to RecordDeclarationSyntax too? #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this to RecordDeclarationSyntax too?

We are not making any changes for records, so no changes necessary, even if they wouldn't make any difference (which is unlikely).

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Feb 6, 2023
@AlekseyTs
Copy link
Contributor Author

@cston, @jjonescz, @dotnet/razor-compiler For the second review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants