Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for some "Primary Constructors" IDE scenarios. #66774

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Add tests for some "Primary Constructors" IDE scenarios. #66774

merged 1 commit into from
Feb 13, 2023

Conversation

AlekseyTs
Copy link
Contributor

@AlekseyTs AlekseyTs requested review from a team as code owners February 9, 2023 15:11
jcouv
jcouv approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiler changes (test-only) LGTM Thanks (iteration 1)

@AlekseyTs
Copy link
Contributor Author

@akhera99, @CyrusNajmabadi, @dotnet/roslyn-ide Please review

@AlekseyTs AlekseyTs merged commit c61ca2c into dotnet:features/PrimaryConstructors Feb 13, 2023
@allisonchou allisonchou mentioned this pull request Mar 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@jjonescz jjonescz Awaiting requested review from jjonescz

@cston cston Awaiting requested review from cston

@akhera99 akhera99 Awaiting requested review from akhera99

Assignees
No one assigned
Labels
Area-Compilers Feature - Primary Constructors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekseyTs @CyrusNajmabadi @jcouv