Implement legacy options provider for code actions in workspace layer #66798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
reviewed
Feb 10, 2023
| @@ -20,7 +18,6 @@ namespace Microsoft.CodeAnalysis.Options | |||
| internal sealed class LegacyGlobalOptionsWorkspaceService : ILegacyGlobalOptionsWorkspaceService | |||
There was a problem hiding this comment.
📝 This needs to be updated to use ServiceLayer.Editor
There was a problem hiding this comment.
Does it? This implements a different service interface than what I added to workspace
There was a problem hiding this comment.
I missed that it was a different interface, but yes since this is the editor layer. It would be reasonable to add a default implementation in the workspaces layer (even if it just takes no action) and we wouldn't want it to conflict in that case.
There was a problem hiding this comment.
I can follow up on that when I get back.
sharwell
approved these changes
Mar 1, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new service interface
ILegacyGlobalCleanCodeGenerationOptionsWorkspaceServicethat is used in a few places in workspace layer where a provider forCleanCodeGenerationOptionsis needed for fallback options, but the fallback options can't currently be passed to that code from a higher layer.Previously the provider was retrieved from
ILegacyGlobalOptionsWorkspaceService, but the implementation of that service can't be moved to Workspace layer due to additional dependencies.Uses the recently introduced
IOptionsReaderto eliminate duplicate option reading code.Fixes #66779