WithFrozenPartialSemantics freezing linked documents #66904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhera99
changed the title
| } | ||
|
|
||
| var linkedDocs = docBuilder.AsImmutable(); | ||
| var linkedTrees = treeBuilder.AsImmutable(); |
There was a problem hiding this comment.
actually... i don't know why you even need these. i also don't know why they're called linkedXXX since they also contain the non-linked items.
src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/CoreTest/SolutionTests/SolutionWithSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/CoreTest/SolutionTests/SolutionWithSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
| @@ -1685,6 +1697,48 @@ public SolutionState WithFrozenPartialCompilationIncludingSpecificDocument(Docum | |||
| } | |||
| } | |||
|
|
|||
| internal ImmutableArray<DocumentId> GetRelatedDocumentIds(DocumentId documentId) | |||
| return false; | ||
| } | ||
|
|
||
| return projectState?.ProjectInfo.Language == args.language; |
There was a problem hiding this comment.
Suggested change
| return projectState?.ProjectInfo.Language == args.language; | |
| return projectState.ProjectInfo.Language == args.language; |
|
|
||
| private static ImmutableArray<DocumentId> FilterDocumentIdsByLanguage(SolutionState solution, ImmutableArray<DocumentId> documentIds, string language) | ||
| => documentIds.WhereAsArray( | ||
| (documentId, args) => |
There was a problem hiding this comment.
Suggested change
| (documentId, args) => | |
| static (documentId, args) => |
src/Workspaces/CoreTest/SolutionTests/SolutionWithSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/CoreTest/SolutionTests/SolutionWithSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/CoreTest/SolutionTests/SolutionWithSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/CoreTest/SolutionTests/SolutionWithSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/CoreTest/SolutionTests/SolutionWithSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
jasonmalinowski
approved these changes
Feb 17, 2023
src/Workspaces/CoreTest/SolutionTests/SolutionWithSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/CoreTest/SolutionTests/SolutionWithSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/CoreTest/SolutionTests/SolutionWithSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
akhera99
changed the title
ghost
added this to the 
arunchndr
pushed a commit
that referenced
this pull request
Mar 1, 2023
* wip * Add test * fix * feedback * feedback * wip * fix * cleanup * feedback * fix * remove unused method * formatting * feedback --------- Co-authored-by: [email protected] <[email protected]>
arunchndr
added a commit
that referenced
this pull request
Mar 1, 2023
17.5 port: WithFrozenPartialSemantics freezing linked documents (#66904)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: AB#1744772
Previously, when calling Document's
WithFrozenPartialSemanticswe would only freeze that document. Changed it so we retrieve all the linked documents as well and freeze all of them.