Fix marshalability of IWorkspaceProject.StartBatchAsync #67048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/VisualStudio/Core/Def/ProjectSystem/BrokeredService/WorkspaceProject.cs
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Feb 25, 2023
We have to make this return an interface marked with [RpcMarshalable], and since that can't really use IAsyncDisposable to say when it's done, I'm adding an explicit Apply method to make up for it.
jasonmalinowski
force-pushed
the
fix-batch-api
branch
from
18feba0 to
96976ae
Compare
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to make this return an interface marked with [RpcMarshalable], and since that can't really use IAsyncDisposable to say when it's done, I'm adding an explicit Apply method to make up for it.