Merge 'dotnet/main' into PrimaryConstructors #67111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up the priority of the 'fix formatting' fixer to 'high'
Results of running 'make member readonly' on IDE
Move to "UseDeconstruction" to `VerifyCS`
Exclude CSharp.EditorFeature from vs_perf_designtime_ide_searchtest
Improve 'convert regular to raw-string' for common cases (like test code).
Extract remote keep-alive code into its own component
…n the driver, tracked by dotnet#67084
* Change block structure options to editorconfig-like name * Move brace completion/classification/prefer hashcode/color scheme to new name * Move completion options to new names * Move provide date and time completion to new name * Move diagnostic options to new names * Move documentation and documentOutline to new name * Move editor component options to new name * Move extract method option to new name * Move fading options to new name * Move database storage to new name * Move find usage options to new name * Move formatting options to new name * Move generate code option to new name * Move implement type options to new name * Move all the inline hints options to new name * Move inline rename options to new name * Move Json features option to new name * Move key binding reset options to new name * Move logger option and lsp options to new name * Move quick info options to new name * Move regular expression options to new name: * Move solution crawler options to new name * Move spilit comment/string options to new name * Move stacktrace explorer to new name * Move suggestion option async to new name * Move symbol search option to new name * Move task list options to new name * Move format string option to new name * Move workspace configuration to new name * Move xaml options to new name * Move internal diagnostics options to new name * Move internal feature on off options to new name * Move solution crawler options to new name * Move service feature on off options to new name * Fix the wrongly upcase OOP * Change csharp_split_string_literal_options_enabled to csharp_split_string_literal_on_return * Rename Inline hints view options * Rename diagnostic tagging options * Change FormattingOptonsMetadata * Rename block structure options * Rename format on close brace * Rename classsify * Rename prefer hashcode * Rename color scheme * Rename completion options * Revisit block structure options * Rename date and time completion, pull diagnostic, comment generation, document outline * Rename format, constructor generation, hashcode and equals generation, implement type options * Rename inline hints options * Rename rename options * Rename diagnostics options * Rename InternalFeatureOnOff options' * Rename Json options * Rename keybidingResetOptions * Rename logger options * Rename lsp options * Rename navigator bar and regex options * Rename show signature, naming, solution crawler split comment, stacktrace explorer, suggestions, symbol search, and suugested types options * Rename task list item, wrap line length, and report invalid string dot format calls options * Rename workspace and xaml options * rename hide in advanced members * Rename semantic_colorizer and syntactic colorizer * Fully qualified lsp * Fully qualified lsp in xaml options * Unify the enable word * Unify the disable word * Remove 'all' from display_inline_hints_while_pressing_alt_f1 * Rename dotnet_inline_hints_colorize to dotnet_colorize_inline_hints * Rename dotnet_tagging_pull_diagnostic to dotnet_pull_diagnostic_tagging * Change extracting to extract in dotnet_allow_best_effort_when_extracting_method * Rename dotnet_select_all_when_generate_overrides * Rename dotnet_generate_equals_and_get_hash_code_from_members_when_generate_operators * Rename dotnet_generate_equals_and_get_hash_code_from_members_when_implement_iequatable * Rename dotnet_add_null_checks_when_generate_constructor_from_members * Remove the duplicate AddNullChecksToConstructorsGeneratedFromMembers * Rename dotnet_enable_oop_64_bit * Rename dotnet_enable_oop_server_gc * Rename dotnet_enable_oop_core_clr * Rename dotnet_split_comment * Rename dotnet_completion_enter_key_behavior * Rename dotnet_don't_put_out_or_ref_on_struct_when_extract_method * Rename dotnet_insertion_behavior_when_implement_type * Rename dotnet_property_generation_behavior_when_implement_type * Rename dotnet_suggest_for_types_in_reference_assemblies * Rename SymbolSearchOptions * Rename intellicode options * Rename FindUsagesOptions * Rename xaml options * Rename dotnet_visual_studio_workspace_partial_load_mode * Rename dotnet_code_style_prefer_system_hash_code * Rename dotnet_smart_indent * Fix the missing xaml options * Change to dotent for csharp_show_new_snippet_experience_feature_flag, csharp_show_new_snippet_experience, csharp_disable_unnamed_symbol_completion, csharp_normal_diagnostic_mode, csharp_event_hook_up, visual_basic_format_on_save, csharp_enable_snippets, csharp_open_stack_trace_explorer_on_focus, visual_basic_visual_studio_navigation_options_navigate_to_object_browser and csharp_lsp_pull_diagnostics * Rename SplitStringLiteralOptions * Rename InlineHintsViewOptions * Rename DiagnosticsTaggingOptions * Rename InlineDiagnosticsOptions * Rename FormattingOptions * Rename InlineRenameUIOptionsStorage * Rename CompletionViewOptions * Rename RemoteHostOptions * Rename SplitCommentOptions * Rename SuggestionsOptions * Rename InternalDiagnosticsOptions * Rename LspOptions * Rename DocumentOutlineOptions * Rename ColorSchemeOptions * Rename KeybindingResetOptions * Rename LoggerOptions * Rename StackTraceExplorer options * Rename SymbolSearchGlobalOptions * Rename VisualStudioLoggingOptionsMetadata * VisualStudioNavigationOptions * Rename FadingOptions * Revert "Rename FadingOptions" This reverts commit 09fb3ce. * Move BranceMatcingOptions to seperate file * Move DiagnosticsClassificationOptions to seperate file * Move SemanticsColorizer to seperate file * Move AutomaticLineEnder and SyntacticColorizer options to seperate files * Move smart indenter options to seperate file * Move dotnet_squiggles to seperate file * Move FormatOnSave to seperate file * Move RenameTracking options to seperate file * Move EventHookup to seperate file * Move snippets options to seperate file * Move VirtualMemoryNotificationListener options to seperate file and remove InternalFeatureOnOffOptions * Fix the namespace of SmartIndent * Correct the namespace * Add enable in rename tracking * Remove the features in implement type options * Rename to lsp * Rename dotnet_navigate_to_object_browser * Rename dotnet_automatic_line_ender * Add enable to brace matching * Add enable to classification and squiggles * Add enable to event hookup * Add enable to smart indenter * Add enable to async sugguestions * Remove under_cursor suffix * Add visual studio prefix to Color scheme * Add visual_studio to keybinding reset options * Add visual_studio prefix in logger options storage * Add visual_studio prefix to SymbolSearchGlobalOptionStorage * Add visual_studio prefix to VisualStudioLoggingOptionsStorage * Add visual_studio prefix to navigate to object browser * Remove dotnet in color scheme * Replace visual_studio_dotnet to visual_studio
[Lightbulb Perf] Improve the caching logic in OOP DiagnosticComputer
Follow-up change to dotnet#67058. We also trim down the analyzers to run for each code action priority bucket, so the analyzer priority needs to match the fixer priority. I'll add a unit test in a follow-up PR to verify that all our analyzer/fixer pairs have matching priority.
Bump up priority for formatting analyzer
…tchingHelpers.cs Co-authored-by: Ankita Khera <[email protected]>
Improve the spans that 'add parameter check' is supported in
Fix issue in 'use pattern matching'
…cturedBinLog Update LSIF generator to latest bin log reader
cston
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.