Cleanup ArgumentOutOfRange exception for LSP.Range

[beccamc]

This is a correction to PR 68081, which went in without appropriate approval. PR 68081 added an error message when requesting a line beyond the length of the file.

The requested line number {0} must be less than the number of lines {1}.

Two things here...

• Added the issue for removing the ProtocolConversions exception handling code that was added by Cyrus for this investigation
• Added a test case for a negative line number

[beccamc]

Chuck made a Comment in the other PR. Is the new argument resource string necessary? It looks like the caller in ProtocolConversions will catch the exception and wrap the exception in an exception that includes the line count.

That exception catching code is here, and was added by Cyrus. I've added an issue for removing it when this investigation is done. Without this code catching the exception and adding the line numbers, I think its useful to still throw an exception saying The requested line number {0} must be less than the number of lines {1}

Open to feedback

[cston]

I agree, it seems useful to throw an ArgumentOutOfRange exception from TextLineCollection.LinePosition(), but I don't think we need a dedicated resource string for that case, particularly since the caller here is catching and wrapping the exception and including the line count.

[beccamc]

The catching code here will be removed when the investigation into these ArgumentOutOfRange exceptions is finished. When that code is removed there will not be logging for the total number of lines in the document.

Is there a cost to having a resource string here? It seems like an easy thing to add that will bring clarity to something that has been a point of confusion in the LSP spec.

[beccamc]

Basically this catching code on line 211 should not stay here permanently because it hides the true cause of the ArgumentException. It should be removed once we round up the ArgumentOutOfRange exceptions.

We've already proven that for the case of end.Line == lines.Count it is difficult to determine the source of the error. We needed the logging on line 211 to do it. Additionally, given that the case of end.Line == lines.Count might not intuitively be seen an error, I believe that we should throw a very clear error message as to what has been done wrong.