Ensure that we always run all diagnostic suppressors for single file analysis #68270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ysis Fixes [AB#1819603](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1819603) If CompilationWithAnalyzers host passes in suppressors into CompilationWithAnalyzers constructor, but does not pass these suppressors into the public APIs on it that compute and return diagnostics for a given subset of analyzers, then the driver skips executing these suppressors on the reported diagnostics. This change ensures that the AnalyzerDriver is always passed in all the DiagnosticSuppressors to execute, regardless of whether or not they are part of the input set of analyzers passed into the public APIs on CompilationWithAnalyzers. Verified that the added unit test fails before this change.
dotnet-issue-labeler
bot
added
the
untriaged
mavasani
commented
May 19, 2023
Comment on lines
+363
to
+370
| var analyzers = analysisScope.Analyzers; | ||
| if (!suppressors.IsEmpty) | ||
| { | ||
| // Always provide all the diagnostic suppressors to the driver. | ||
| // We also need to ensure we are not passing any duplicate suppressor instances. | ||
| var suppressorsInAnalysisScope = analysisScope.Analyzers.OfType<DiagnosticSuppressor>().ToImmutableHashSet(); | ||
| analyzers = analyzers.AddRange(suppressors.Where(suppressor => !suppressorsInAnalysisScope.Contains(suppressor))); | ||
| } |
There was a problem hiding this comment.
This is the core fix
cston
approved these changes
May 19, 2023
|
@dotnet/roslyn-compiler for another review - trivial fix |
RikkiGibson
reviewed
May 25, 2023
src/Compilers/Core/Portable/DiagnosticAnalyzer/CompilationWithAnalyzers.cs
Show resolved
Hide resolved
RikkiGibson
approved these changes
May 25, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#1819603
If CompilationWithAnalyzers host passes in suppressors into CompilationWithAnalyzers constructor, but does not pass these suppressors into the public APIs on it that compute and return diagnostics for a given subset of analyzers, then the driver was skipping executing these suppressors on the reported diagnostics.
This change ensures that the AnalyzerDriver is always passed in all the DiagnosticSuppressors to execute, regardless of whether or not they are part of the input set of analyzers passed into the public APIs on CompilationWithAnalyzers.
Verified that the added unit test fails before this change.