Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only Left and returnValue gets checked for dynamic in signature #69214

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Only Left and returnValue gets checked for dynamic in signature #69214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Compilers/CSharp/Portable/Compilation/CSharpCompilation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4127,7 +4127,7 @@ void validateSignature()
// Dynamic built-in operators allow virtually all operations with all types. So we do no further checking here.
if (csharpReturnType.TypeKind is TypeKind.Dynamic ||
csharpLeftType.TypeKind is TypeKind.Dynamic ||
csharpReturnType.TypeKind is TypeKind.Dynamic)
csharpRightType.TypeKind is TypeKind.Dynamic)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely looks like a good bug you've caught. :)

would need a test to go along with this. Thsi also might be a breaking change in some way. Compiler will have to look into that and see if this needs to be doc'ed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it will functionally change something because I can't seem to figure out how to have the right dynamic type without a return type that is also dynamic.

{
return;
}
Expand Down