Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade NuGet.Frameworks to fix loading projects with the 7.0.4xx SDK #69354

Merged
merged 1 commit into from
Aug 4, 2023

Commits on Aug 3, 2023

  1. Upgrade NuGet.Frameworks to fix loading projects with the 7.0.4xx SDK

    The 7.0.4xx SDKs ship with a newer version of NuGet.Frameworks than
    we are shipping. Due to a complicated set of interactions of how
    the various AssemblyLoadingContexts work (or don't work as expected!),
    this means that when our LSP server uses MSBuildWorkspace to load
    projects, it'll end up using the NuGet.Frameworks we use here rather
    than the MSBuild one, causing load issues.
    
    The underlying problem is tracked with
    dotnet#61454, although I still need
    to write up the full situation in that bug since back in June we ended
    up running into a similar issue and had lots of deep analysis of it.
    Fixing the problem requires changes in several different repositories
    (and all involving AssemblyLoadContexts, so the changes are very
    technical) so for now we'll just bump the version.
    
    Fixes dotnet/vscode-csharp#5980
    jasonmalinowski committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    189b483 View commit details
    Browse the repository at this point in the history