Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading lsp server logs #69378

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Aug 4, 2023

We've gotten a fair number of reports of the language server hanging on startup because the logs look like

Dotnet path: c:\Users\dabarbet\AppData\Roaming\Code\User\globalStorage\ms-dotnettools.vscode-dotnet-runtime\.dotnet\7.0.9\dotnet.exe
Activating C# + C# Dev Kit + C# IntelliCode...
info: LanguageServerHost[0]
      Starting server...

This updates the last line to instead indicate that the server has started.

@dibarbet dibarbet added the LSP issues related to the roslyn language server protocol implementation label Aug 4, 2023
@dibarbet dibarbet requested a review from a team as a code owner August 4, 2023 01:45
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 4, 2023
@dibarbet dibarbet enabled auto-merge August 4, 2023 01:56
@dibarbet dibarbet merged commit 7dc10ec into dotnet:main Aug 4, 2023
24 checks passed
@ghost ghost added this to the Next milestone Aug 4, 2023
@dibarbet dibarbet deleted the fix_misleading_log branch August 4, 2023 03:15
@dibarbet dibarbet modified the milestones: Next, 17.8 P2 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure LSP issues related to the roslyn language server protocol implementation untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants