-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analyzer/fixer to suggest changing code like ImmutableArray.CreateBuilder<int>(); ...
to a collection expression.
#69500
Merged
CyrusNajmabadi
merged 69 commits into
dotnet:main
from
CyrusNajmabadi:useCollectionExpressionForBuilder2
Aug 16, 2023
Merged
Add analyzer/fixer to suggest changing code like ImmutableArray.CreateBuilder<int>(); ...
to a collection expression.
#69500
CyrusNajmabadi
merged 69 commits into
dotnet:main
from
CyrusNajmabadi:useCollectionExpressionForBuilder2
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essionForBuilder2
…essionForBuilder2
This was referenced Aug 15, 2023
akhera99
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #69473.
Looks for code like:
And suggests converting to:
This PR Involves a lot of refactoring of hte current analyzer/fixers to more broadly support this scenario. Specifically, the existing 'use collection initializer' already has teh support for analyzing successive statements to see if they're complimentary with a collection-initializer/expression.
But we needed to extract out pieces as that analyzer/fixer assumes you have an initial collection of hte form
new Collection<int>()
, and it also assumes you're replacing the intitial declaration point (whereas with builders you want to update the place wherebuilder.ToXXX()
is called.