Support creating binlogs for the language server's design time builds #69572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise passing in a BinaryLogger won't actually log any of the task inputs, which is the most important bit.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
jasonmalinowski
commented
Aug 16, 2023
...atures/LanguageServer/Protocol/Features/Options/LanguageServerProjectSystemOptionsStorage.cs
Outdated
Show resolved
Hide resolved
dibarbet
reviewed
Aug 17, 2023
...atures/LanguageServer/Protocol/Features/Options/LanguageServerProjectSystemOptionsStorage.cs
Outdated
Show resolved
Hide resolved
...ageServer/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/LanguageServerProjectSystem.cs
Show resolved
Hide resolved
dibarbet
approved these changes
Aug 17, 2023
jasonmalinowski
force-pushed
the
add-support-for-binlog-logging
branch
from
d012eef
to
8aa2bb9
Compare
jasonmalinowski
removed
the
untriaged
JoeRobich
reviewed
Aug 18, 2023
jasonmalinowski
force-pushed
the
add-support-for-binlog-logging
branch
2 times, most recently
from
c2e8ad6
to
dea3097
Compare
This allows you to configure a directory where we will write binlogs for any design time builds. This is only needed when debugging project system issues, but when you need this, you really need this.
jasonmalinowski
force-pushed
the
add-support-for-binlog-logging
branch
from
dea3097
to
b4cc984
Compare
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to configure a directory where we will write binlogs for any design time builds. This is only needed when debugging project system issues, but when you need this, you really need this.