Move helpers for 'use collection expression'. #69581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Aug 17, 2023
| @@ -454,4 +456,298 @@ or ImplicitStackAllocArrayCreationExpressionSyntax | |||
|
|
|||
| return matches.ToImmutable(); | |||
| } | |||
|
|
|||
| public static bool IsCollectionFactoryCreate( | |||
CyrusNajmabadi
commented
Aug 17, 2023
| @@ -123,16 +123,15 @@ public bool ValuePatternMatches(TExpressionSyntax expression) | |||
| /// <summary> | |||
| /// Analyze an expression statement to see if it is a legal call of the form <c>val.Add(...)</c>. | |||
| /// </summary> | |||
| public bool TryAnalyzeAddInvocation<TExpressionStatementSyntax>( | |||
| TExpressionStatementSyntax statement, | |||
| public bool TryAnalyzeAddInvocation( | |||
There was a problem hiding this comment.
changed this to actually only analyze the invocation-expression itself, not hte containing expression-statement. that's because in the next PR .Add/.AddRange may be part of a long expression chain, not standalone like foo.Add(x);
akhera99
approved these changes
Aug 17, 2023
3 tasks
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These helpers are useful for the next upcoming analyzer/fixer, which finds things of the form
ImmutableArray.Create(1, 2, 3).Add(x).Concat(other).ToArray()(and similar expressions) and offers to conver to[1, 2, 3, x, .. other)]