Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle long extension invocation chains #69831

Merged
merged 11 commits into from
Sep 12, 2023
Merged

Handle long extension invocation chains #69831

merged 11 commits into from
Sep 12, 2023

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Sep 6, 2023 •
edited
Loading

Fixes AB#1874763.
Inspired by #67913.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 6, 2023
@jjonescz jjonescz force-pushed the 1874763-ExtensionCallChain branch 4 times, most recently from cb27afd to c737fb4 Compare September 7, 2023 07:49
@jjonescz jjonescz marked this pull request as ready for review September 7, 2023 10:55
@jjonescz jjonescz requested a review from a team as a code owner September 7, 2023 10:55
@jaredpar jaredpar added this to the 17.8 milestone Sep 7, 2023
@AlekseyTs
Copy link
Contributor

Done with review pass (commit 1)

@jjonescz jjonescz marked this pull request as draft September 8, 2023 10:27
@AlekseyTs
Copy link
Contributor

Done with review pass (commit 7)

AlekseyTs
AlekseyTs reviewed Sep 11, 2023
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 10)

@jjonescz jjonescz marked this pull request as ready for review September 11, 2023 14:06
AlekseyTs
AlekseyTs approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 10)

@jjonescz jjonescz enabled auto-merge (squash) September 12, 2023 08:27
@jjonescz jjonescz merged commit bc41e82 into dotnet:main Sep 12, 2023
25 checks passed
@jjonescz jjonescz deleted the 1874763-ExtensionCallChain branch September 12, 2023 09:53
@ghost ghost modified the milestones: 17.8, Next Sep 12, 2023
@allisonchou allisonchou mentioned this pull request Sep 13, 2023
Closed
@jjonescz jjonescz mentioned this pull request Sep 25, 2023
Merged
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@333fred 333fred 333fred approved these changes

Assignees

@AlekseyTs AlekseyTs

Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P3
Development

Successfully merging this pull request may close these issues.
5 participants
@jjonescz @AlekseyTs @333fred @jaredpar @Cosifne