Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include URI string when we get an exception creating a URI #69840

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Sep 7, 2023

We're getting URI errors when creating file watcher requests. Unfortunately the base exception doesn't include the failing URI, so we aren't able to tell what is going wrong.

This change wraps the exception to include the uri and original string.
Related to microsoft/vscode-dotnettools#449

@dibarbet dibarbet merged commit 8ad9144 into dotnet:main Sep 7, 2023
24 checks passed
@dibarbet dibarbet deleted the log_uri_failures branch September 7, 2023 17:47
@ghost ghost added this to the Next milestone Sep 7, 2023
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants