Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source build trying to consume StreamJsonRpc #69854

Conversation

jasonmalinowski
Copy link
Member

@jasonmalinowski jasonmalinowski commented Sep 7, 2023

Right now the use of StreamJsonRpc is only being used for our LSP server which doesn't build in source build anyways. So we can exclude it here for now.

Fixes #69847

Right now the use of StreamJsonRpc is only being used for our LSP server
which doesn't build in source build anyways. So we can exclude it here
for now.
@jasonmalinowski jasonmalinowski requested a review from a team as a code owner September 7, 2023 23:26
@jasonmalinowski jasonmalinowski self-assigned this Sep 7, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 7, 2023
@jasonmalinowski jasonmalinowski merged commit 08a9e51 into dotnet:main Sep 8, 2023
22 of 24 checks passed
@ghost ghost added this to the Next milestone Sep 8, 2023
@jasonmalinowski jasonmalinowski deleted the remove-streamjsonrpc-from-source-build branch September 8, 2023 17:16
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roslyn has introduced many source-built prebuilts
3 participants