Update default razor project cache file name #70156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
dibarbet
approved these changes
Sep 27, 2023
| @@ -14,7 +14,7 @@ internal sealed class RazorWorkspaceListenerInitializer | |||
| { | |||
| // This should be moved to the Razor side once things are announced, so defaults are all in one | |||
| // place, in case things ever need to change | |||
| private const string _projectRazorJsonFileName = "project.razor.vscode.json"; | |||
| private const string _projectRazorJsonFileName = "project.razor.vscode.bin"; | |||
There was a problem hiding this comment.
Would be good to move this to the razor side entirely (and have Roslyn consume it via an input param or option) as mentioned in the comment. But no need to do now if this needs to go in urgently.
| @@ -14,7 +14,7 @@ internal sealed class RazorWorkspaceListenerInitializer | |||
| { | |||
| // This should be moved to the Razor side once things are announced, so defaults are all in one | |||
| // place, in case things ever need to change | |||
| private const string _projectRazorJsonFileName = "project.razor.vscode.json"; | |||
| private const string _projectRazorJsonFileName = "project.razor.vscode.bin"; | |||
There was a problem hiding this comment.
Good idea to update this, but its only a fallback and probably will never be used. The real value to use gets passed in on the command line here: https://github.com/dotnet/vscode-csharp/blob/main/src/razor/src/razorLanguageServerClient.ts#L245
I took the liberty: dotnet/vscode-csharp#6447
There was a problem hiding this comment.
I was wrong, this is used, but only for writing the file. Reading the file needs the other PR I opened. Sorry, holiday brain.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on dotnet/razor#9270