Add support for using Mono to load .NET Framework projects #70263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
jasonmalinowski
force-pushed
the
add-mono-support
branch
2 times, most recently
from
da9b392
to
9b0e7f1
Compare
dibarbet
reviewed
Oct 6, 2023
...anguageServer/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/BuildHostProcessManager.cs
Show resolved
Hide resolved
...ageServer/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/LanguageServerProjectSystem.cs
Show resolved
Hide resolved
| } | ||
| else | ||
| { | ||
| _logger.LogCritical("No compatible MSBuild instance could be found."); |
There was a problem hiding this comment.
I kind of preferred how it was before where we would explicitly return false in all the failure cases. IMHO made it a bit easier to read.
There was a problem hiding this comment.
I got too scared that we'd have a place where we returned true but forgot to call register or vice versa.
...anguageServer/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/BuildHostProcessManager.cs
Show resolved
Hide resolved
We'll use this on Mac and Linux; we already had equivalent support on Windows. MonoMSBuildDiscovery.cs is largely a copy of the code from these paths, with some tweaks to remove Omnisharp scenarios that don't apply for us. - https://github.com/OmniSharp/omnisharp-roslyn/blob/dde8119c40f4e3920eb5ea894cbca047033bd9aa/src/OmniSharp.Host/MSBuild/Discovery/Providers/MonoInstanceProvider.cs - https://github.com/OmniSharp/omnisharp-roslyn/blob/dde8119c40f4e3920eb5ea894cbca047033bd9aa/src/OmniSharp.Host/MSBuild/Discovery/MSBuildInstanceProvider.cs Closes dotnet/vscode-csharp#5721
jasonmalinowski
force-pushed
the
add-mono-support
branch
from
9b0e7f1
to
80e707d
Compare
dibarbet
approved these changes
Oct 6, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll use this on Mac and Linux; we already had equivalent support on Windows. MonoMSBuildDiscovery.cs is largely a copy of the code from these paths, with some tweaks to remove Omnisharp scenarios that don't apply for us.
Closes dotnet/vscode-csharp#5721