Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix emitting Custom Attribute deltas #70350

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Fix emitting Custom Attribute deltas #70350

merged 3 commits into from
Oct 18, 2023

Conversation

tmat
Copy link
Member

@tmat tmat commented Oct 12, 2023 •
edited
Loading

Fixes #70357

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 12, 2023
@tmat tmat marked this pull request as ready for review October 15, 2023 01:06
@tmat tmat requested a review from a team as a code owner October 15, 2023 01:06
@tmat tmat mentioned this pull request Oct 15, 2023
Merged
@tmat
Copy link
Member Author

tmat commented Oct 15, 2023 •
edited
Loading

@davidwengier @dotnet/roslyn-compiler ptal

@tmat tmat enabled auto-merge (squash) October 17, 2023 19:23
auto-merge was automatically disabled October 17, 2023 19:52

Pull request was closed

@jjonescz
Copy link
Member

@tmat looks like this was closed by mistake? reopening

@jjonescz jjonescz reopened this Oct 18, 2023
@tmat
Copy link
Member Author

tmat commented Oct 18, 2023 •
edited
Loading

@jjonescz Thanks, yeah github closed it because the other PR was closed.

@tmat tmat merged commit 4795305 into dotnet:main Oct 18, 2023
25 checks passed
@tmat tmat deleted the EncAttributesFix branch October 18, 2023 16:33
@ghost ghost added this to the Next milestone Oct 18, 2023
@allisonchou allisonchou mentioned this pull request Oct 20, 2023
Closed
@jjonescz jjonescz modified the milestones: Next, 17.9 P1 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cston cston cston approved these changes

@jjonescz jjonescz jjonescz approved these changes

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.9 P1
Development

Successfully merging this pull request may close these issues.

EnC: Custom attribute deltas are emitted incorrectly
4 participants
@tmat @jjonescz @davidwengier @cston