Update breaking change docs #70435
Merged
Update breaking change docs #70435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
force-pushed
the
updateBCs
branch
from
8707239
to
e10c59f
Compare
CyrusNajmabadi
commented
Oct 18, 2023
docs/Breaking API Changes.md
Outdated
| @@ -96,3 +96,11 @@ Now the reason will be reported more accurately as `IncrementalStepRunReason.New | |||
| The value of `Assembly.Location` previously held the location on disk where an analyzer or source generator was loaded from. This could be either the original location or the shadow copy location. In 4.8 this will be `""` in certain cases when running on non Windows platforms. This is due the compiler server loading assemblies using `AssemblyLoadContext.LoadFromStream` instead of loading from disk. | |||
|
|
|||
| This could already happen in other load scenarios but this change moves it into mainline build scenarios. | |||
|
|
|||
| # Version XXX | |||
There was a problem hiding this comment.
@arunath do you know what i would put here.
There was a problem hiding this comment.
Still on 4.8.0-3. So you converge with the section above.
arunchndr
approved these changes
Oct 18, 2023
docs/Breaking API Changes.md
Outdated
| @@ -96,3 +96,11 @@ Now the reason will be reported more accurately as `IncrementalStepRunReason.New | |||
| The value of `Assembly.Location` previously held the location on disk where an analyzer or source generator was loaded from. This could be either the original location or the shadow copy location. In 4.8 this will be `""` in certain cases when running on non Windows platforms. This is due the compiler server loading assemblies using `AssemblyLoadContext.LoadFromStream` instead of loading from disk. | |||
|
|
|||
| This could already happen in other load scenarios but this change moves it into mainline build scenarios. | |||
|
|
|||
| # Version XXX | |||
There was a problem hiding this comment.
Still on 4.8.0-3. So you converge with the section above.
CyrusNajmabadi
commented
Oct 18, 2023
CyrusNajmabadi
commented
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.