-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip elements with false conditions during evaluation #70496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues in some projects where the evaluation of the element will fail if the condition does not hold
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
Issues and PRs which have not yet been triaged by a lead
labels
Oct 20, 2023
3 tasks
src/Workspaces/Core/MSBuild.BuildHost/Build/ProjectBuildManager.cs
Outdated
Show resolved
Hide resolved
jasonmalinowski
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I can sign off on this one, in the sense that people smarter than I would know the real questions to ask.
jasonmalinowski
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was that a specific item group had a condition to prevent an empty property. Inside the item group, it used
[MSBuild]::VersionEquals
which cannot handle an empty value.However, evaluation was attempting to evaluate it anyway - which threw an error causing the project to fail to load.
This changes evaluation to skip item groups with false conditions.
DRAFT - confirming with msbuild if this property should always be set on evaluation
Resolves dotnet/vscode-csharp#6356