Ensure errors are reported when compiler is unable to emit a required attribute. #70556
Conversation
… attribute. Related to dotnet#70338.
dotnet-issue-labeler
bot
added
the
untriaged
src/Compilers/CSharp/Portable/Symbols/Attributes/AttributeData.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Jones <[email protected]>
|
@dotnet/roslyn-compiler For the second review. |
| @@ -48,7 +48,7 @@ internal abstract partial class EmbeddedTypesManager< | |||
| where TModuleCompilationState : CommonModuleCompilationState | |||
| where TEmbeddedTypesManager : EmbeddedTypesManager<TPEModuleBuilder, TModuleCompilationState, TEmbeddedTypesManager, TSyntaxNode, TAttributeData, TSymbol, TAssemblySymbol, TNamedTypeSymbol, TFieldSymbol, TMethodSymbol, TEventSymbol, TPropertySymbol, TParameterSymbol, TTypeParameterSymbol, TEmbeddedType, TEmbeddedField, TEmbeddedMethod, TEmbeddedEvent, TEmbeddedProperty, TEmbeddedParameter, TEmbeddedTypeParameter> | |||
| where TSyntaxNode : SyntaxNode | |||
| where TAttributeData : AttributeData, Cci.ICustomAttribute | |||
| where TAttributeData : class, Cci.ICustomAttribute | |||
There was a problem hiding this comment.
Was there a reason for this change?
Yes, I want to prevent the common component to take advantage of the APIs available from AttributeData.
There was a problem hiding this comment.
Among other things, this ensures that I adjusted all "interesting" code without creating error tests for all affected attributes.
| return attributeConstructor.GetUseSiteInfo().DiagnosticInfo; | ||
|
|
||
| case { }: | ||
| return new CSDiagnosticInfo(ErrorCode.ERR_BogusType, string.Empty); |
There was a problem hiding this comment.
AttributeClass?
No. There is nothing wrong with the attribute class here. We simply failed to crack the attribute application, i.e. dealing with some sort of invalid metadata for the specific attribute application. In such cases elsewhere we create UnsupportedMetadataTypeSymbol and this is how we report a use-site error for it.
|
|
||
| If AttributeConstructor IsNot Nothing Then | ||
| Return If(AttributeConstructor.GetUseSiteInfo().DiagnosticInfo, | ||
| ErrorFactory.ErrorInfo(ERRID.ERR_UnsupportedType1, String.Empty)) |
There was a problem hiding this comment.
Same response as for C#
ghost
added this to the 
Related to #70338.