Fix regression in definite assignment analysis for out parameters in presence of local functions. #70563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…presence of local functions. Fixes dotnet#69775.
dotnet-issue-labeler
bot
added
the
untriaged
jjonescz
approved these changes
Oct 26, 2023
|
@dotnet/roslyn-compiler For the second review. |
Why is Refers to: src/Compilers/CSharp/Test/Emit2/FlowAnalysis/RegionAnalysisTests.cs:10787 in 474e087. [](commit_id = 474e087, deletion_comment = False) |
The code is outside of the constructor and x is a constructor parameter. Assuming constructor has been executed, all its parameters are assigned. Besides, this is an error scenario, ref parameters cannot be used outside of the constructor. In reply to: 1781333890 Refers to: src/Compilers/CSharp/Test/Emit2/FlowAnalysis/RegionAnalysisTests.cs:10787 in 474e087. [](commit_id = 474e087, deletion_comment = False) |
cston
approved these changes
Oct 26, 2023
cston
approved these changes
Oct 26, 2023
ghost
added this to the
AlekseyTs
added a commit
to AlekseyTs/roslyn
that referenced
this pull request
Oct 27, 2023
…presence of local functions. (dotnet#70563) Fixes dotnet#69775.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69775.