Modify BKTree.Lookup to pass the threshold to GetEditDistance when there will not be a need for the actual edit distance #70567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…old is passed in that weren't being allowed to execute when called from BKTree.Lookup as it needed the precise edit distance. However, this method only needs the precise edit distance if it has edges to later inspect. I tested this out locally adding stopwatch calls in Lookup with both the old and new code and saw a 25-30% reduction in overall time spent in Lookup with this change.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
original PR that I mucked up via a bad rebase: #70525 |
CyrusNajmabadi
approved these changes
Oct 26, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetEditDistance has various optimizations that are used when a threshold is passed in that weren't being allowed to execute when called from BKTree.Lookup as it needed the precise edit distance. However, this method only needs the precise edit distance if it has edges to later inspect.
I tested this out locally adding stopwatch calls in Lookup with both the old and new code and saw a 25-30% reduction in overall time spent in Lookup with this change.