Watch project.assets.json files for nuget restore #70602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
commented
Oct 27, 2023
| @@ -216,6 +219,27 @@ void UpdateProjectSystemProjectCollection<T>(IEnumerable<T> loadedCollection, IE | |||
| if (newItems.Count != oldItemsCount) | |||
| logger.LogTrace(logMessage, projectFullPathWithTargetFramework, newItems.Count); | |||
| } | |||
|
|
|||
| void WatchProjectAssetsFile(ProjectFileInfo currentProjectInfo, IFileChangeContext fileChangeContext) | |||
There was a problem hiding this comment.
I decided to only watch the actual msbuild property for ProjectAssetsFile here - I took a look at a bit of the O# and CPS code, and it looked they were only looking at that specific property (not for any project.assets.json file in obj/).
jasonmalinowski
approved these changes
Oct 27, 2023
src/Workspaces/Core/MSBuild.BuildHost/MSBuild/Constants/PropertyNames.cs
Outdated
Show resolved
Hide resolved
...Features/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/LoadedProject.cs
Outdated
Show resolved
Hide resolved
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were not reloading the project when a restore happened, until you actually modified a file. This adds a file watcher for the
project.assets.jsonfile to tell us if a restore has happened and that the server needs to reload the project.After: