Workaround vscode bug with returning defaultBehavior from prepareRename #70840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
commented
Nov 15, 2023
| DefaultBehavior = true, | ||
| }; | ||
| var text = await document.GetTextAsync(cancellationToken).ConfigureAwait(false); | ||
| return ProtocolConversions.TextSpanToRange(symbolicRenameInfo.TriggerToken.Span, text); |
There was a problem hiding this comment.
The range here is the initial range to replace - the client takes this range to prefill the rename dialog with the identifier to rename.
There was a problem hiding this comment.
Can you test that this works properly with things like @foo and we don't get weirdness.
There was a problem hiding this comment.
Added a test. This also appears to work better than before as well. For example, what happened before this change is
But now it looks like
|
lol, so neither VS nor VS Code handle that response type? So glad we have a spec 😛 |
CyrusNajmabadi
approved these changes
Nov 15, 2023
3 tasks
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCode bug here - microsoft/vscode-languageserver-node#1363
Returning an explicit range instead of defaultBehavior works.
Resolves https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1916980