Call GetURI when getting a URI for a document #71395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had some code that slipped in that was calling ProtocolConversions.CreateAbsoluteUri(document.FilePath), which is fine for regular documents but skips the special handling around source generated files, so we'd break in those cases. This "fixes" the UriFormatExceptions people are getting, in the sense that you won't get a UriFormatException anymore. If you try to actually go to a source generated document, that'll still be broken until we merge dotnet/vscode-csharp#5858, but at least this means something like a find reference won't completely break if it has a location somewhere in a source generated file.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
approved these changes
Dec 21, 2023
3 tasks
jasonmalinowski
deleted the
fix-uri-creation-errors-for-generated-documents
branch
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some code that slipped in that was calling
ProtocolConversions.CreateAbsoluteUri(document.FilePath), which is fine for regular documents but skips the special handling around source generated files, so we'd break in those cases.This "fixes" the UriFormatExceptions people are getting, in the sense that you won't get a UriFormatException anymore. If you try to actually go to a source generated document, that'll still be broken until we merge dotnet/vscode-csharp#5858, but at least this means something like a find reference won't completely break if it has a location somewhere in a source generated file.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1922993