Ensure we don't leak the request info if a request is cancelled #71737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our trivial RPC system used for the BuildHost only allows a request to be cancelled before it's sent along the wire -- once it's sent across then it's sent for good. But if it was cancelled, we didn't clean up the tracking for it. This was noticed while looking at a change that was potentially adding a cancellation token to the FlushAsync call (which is new in .NET 8.0) and generally ensuring we are explicit with our behavior there. Closes dotnet#71580
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
jasonmalinowski
commented
Jan 20, 2024
| await _sendingStream.FlushAsync().ConfigureAwait(false); | ||
| #pragma warning restore CA2016 | ||
| // The only cancellation we support is cancelling before we are able to write the request to the stream; once it's been written | ||
| // the other side will execute it to completion. Thus cancellationToken is checked here, but nowhere else. |
There was a problem hiding this comment.
And I should say: it's absolutely possible to be fancier here with cancellation handling, but the whole point of this RPC system is to be trivial. And practically MSBuildWorkspace often can't pass a cancellation token anyways so spending time on making this fancier is just a waste of time.
jasonmalinowski
removed
the
untriaged
dibarbet
approved these changes
Jan 31, 2024
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our trivial RPC system used for the BuildHost only allows a request to be cancelled before it's sent along the wire -- once it's sent across then it's sent for good. But if it was cancelled, we didn't clean up the tracking for it.
This was noticed while looking at a change that was potentially adding a cancellation token to the FlushAsync call (which is new in .NET 8.0) and generally ensuring we are explicit with our behavior there.
Closes #71580