Load Roslyn DevKit assemblies into the default ALC #71807
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -31,7 +24,7 @@ private AssemblyLoadContextWrapper(AssemblyLoadContext assemblyLoadContext, Immu | |||
| _logger = logger; | |||
| } | |||
|
|
|||
| public static bool TryLoadExtension(string assemblyFilePath, ILogger? logger, [NotNullWhen(true)] out Assembly? assembly) | |||
| public static bool TryLoadExtension(string assemblyFilePath, ILogger logger, [NotNullWhen(true)] out Assembly? assembly) | |||
There was a problem hiding this comment.
Why does this even take a ILogger if we also passed a logger into this class in the constructor?
There was a problem hiding this comment.
This is static - there is a wrapper instance for each extension, which gets its logger from the parameter here.
| { | ||
| try | ||
| { | ||
| var loadContext = CreateLoadContext(name); | ||
| logger.LogTrace("[{name}] Loading assemblies in {assembliesDirectoryPath}", name, assembliesDirectoryPath); |
There was a problem hiding this comment.
Didn't want to just use interpolated strings?
There was a problem hiding this comment.
theres actually a diagnostic if you do that. See https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2254
I noticed that this file already did it the 'correct' way, so stuck with that here.
| { | ||
| Description = "Full paths of extension assemblies to load (optional).", | ||
| Required = false | ||
| }; | ||
|
|
||
| var devKitDependencyPathOption = new CliOption<string?>("--devKitDependencyPath") |
There was a problem hiding this comment.
Nit, but potentially confusing otherwise: should this be a devKitDependenciesPath? Since there's multiple things in the folder?
There was a problem hiding this comment.
Maybe? I chose non-plural because there is a single dependency project. Not sure
src/Features/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/ServerConfigurationFactory.cs
Show resolved
Hide resolved
This allows extensions to use the host instance of an assembly if they do not ship their own copy
ghost
added this to the 
Resolves #71101
This allows extensions to use the host instance of an assembly if they do not ship their own copy. This did not work previously because the Roslyn DevKit assemblies were loaded into a separate ALC. Now that we ship devkit assemblies in the extension alongside the server, it is safe to load them in the default ALC.
For example, an extension can now access the same instance of VS telemetry that the host has created (and use its telemetry session).
Requires client side PR dotnet/vscode-csharp#6831