Remove legacy incremental-analyzer implementation of TaskList. part2 #72406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
force-pushed
the
removeLegacyTaskListAndPushOption
branch
from
34f671d
to
127efc2
Compare
CyrusNajmabadi
commented
Mar 5, 2024
| @@ -8,21 +8,22 @@ namespace Microsoft.CodeAnalysis.Diagnostics; | |||
|
|
|||
| internal static class InternalDiagnosticsOptionsStorage | |||
| { | |||
| private static readonly EditorConfigValueSerializer<DiagnosticMode> s_editorConfigValueSerializer = EditorConfigValueSerializer.CreateSerializerForEnum<DiagnosticMode>(); | |||
There was a problem hiding this comment.
the crux of this change is that we don't actually support any serializing of the options to control the underlyign diagnosticmode. it's always going to be 'pull' for razor/liveshare. And it's always going to be 'default' for normal diagnostics. 'default' means we then go look at the control tower feature flag (inside vs), which allows us to flip the option back to solution-crawler if we have to pull the emergency brake.
davidwengier
approved these changes
Mar 5, 2024
|
Going to move forward on this. @dibarbet for awareness once you've returned. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #72315. This removes legacy options that are no longer supported as a public way for users to control this behavior.
Note: we still have the internal support for this to be controlled by control tower if we run into any issues.