Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress Lock conversion warnings when using object equality operators #72459

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Suppress Lock conversion warnings when using object equality operators #72459

merged 3 commits into from
Mar 13, 2024

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Mar 8, 2024

Test plan: #71888
Speclet update: dotnet/csharplang#7989

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 8, 2024
@jjonescz jjonescz force-pushed the NativeLock-07-UnobservableConversion branch from 1425e04 to e923e6c Compare March 8, 2024 13:47
@jjonescz jjonescz marked this pull request as ready for review March 8, 2024 15:06
@jjonescz jjonescz requested a review from a team as a code owner March 8, 2024 15:06
@AlekseyTs
Copy link
Contributor

Done with review pass (commit 1)

@jjonescz jjonescz requested a review from AlekseyTs March 11, 2024 10:46
AlekseyTs
AlekseyTs approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 3)

@jjonescz
Copy link
Member Author

@cston @dotnet/roslyn-compiler for a second review, thanks

@jjonescz jjonescz merged commit c40aa62 into dotnet:main Mar 13, 2024
24 checks passed
@jjonescz jjonescz deleted the NativeLock-07-UnobservableConversion branch March 13, 2024 09:12
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 13, 2024
@dotnet-bot dotnet-bot mentioned this pull request Mar 21, 2024
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.10 P3 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cston cston cston approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees
No one assigned
Labels
Area-Compilers New Feature - Lock Type untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.10 P3
Development

Successfully merging this pull request may close these issues.
4 participants
@jjonescz @AlekseyTs @cston @RikkiGibson