Allow VS Code to provide razor source geneator references. #72482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
the
Community
...Server/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/HostDiagnosticAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
...Server/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/HostDiagnosticAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Program.cs
Outdated
Show resolved
Hide resolved
dibarbet
reviewed
Mar 12, 2024
...Server/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/HostDiagnosticAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
| { | ||
| // This method is used to load an analyzer assembly from the specified path. | ||
| // In this simple implementation, we use Assembly.LoadFrom to load the assembly. | ||
| return Assembly.LoadFrom(fullPath); |
There was a problem hiding this comment.
Did you talk with Jason at all about which assembly load context the source generator should be loaded in?
There was a problem hiding this comment.
I don't recall that conversation.
...Server/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/HostDiagnosticAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
...Server/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/HostDiagnosticAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Program.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Program.cs
Outdated
Show resolved
Hide resolved
...Server/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/HostDiagnosticAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
dibarbet
reviewed
Mar 12, 2024
...Server/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/HostDiagnosticAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
- Rename option to be `RazorSourceGenerator` - Cache results in analyzer provider, since result is fixed per roslyn instance - Remove duped names taken out of ProjectSystemProject
dibarbet
reviewed
Mar 12, 2024
...Server/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/HostDiagnosticAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
...Server/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/HostDiagnosticAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
davidwengier
approved these changes
Mar 14, 2024
| @@ -1002,6 +1002,7 @@ public void RemoveAnalyzerReference(string fullPath) | |||
|
|
|||
| private OneOrMany<string> GetMappedAnalyzerPaths(string fullPath) | |||
| { | |||
| fullPath = Path.GetFullPath(fullPath); | |||
There was a problem hiding this comment.
Is this still necessary, now that the full path is being passed in by the client?
There was a problem hiding this comment.
I believe this is needed.
Without this change, variable will be:
s_razorSourceGeneratorSdkDirectory
"Sdks\\Microsoft.NET.Sdk.Razor\\source-generators\\"
fullPath
"C:\\Program Files\\dotnet\\sdk\\6.0.420\\Sdks\\Microsoft.NET.Sdk.Razor\\targets\\..\\\\source-generators\\Microsoft.NET.Sdk.Razor.SourceGenerators.dll"
Path.DirectorySeparatorChar
92 '\\'
and the if condition below would be false and we won't go through getting analyzer references at all:
if (fullPath.LastIndexOf(s_razorSourceGeneratorSdkDirectory, StringComparison.OrdinalIgnoreCase) + s_razorSourceGeneratorSdkDirectory.Length - 1 ==
fullPath.LastIndexOf(Path.DirectorySeparatorChar))
There was a problem hiding this comment.
Oh, that's a surprising value for fullPath. I thought this code also ran in VS, so I'm confused as to how it works there.
|
Removing auto-merge, just in case :) |
dibarbet
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Work Item 1926900
/cc @CyrusNajmabadi @davidwengier @chsienki @dibarbet
Needs dotnet/vscode-csharp#6960 to complete the end to end workflow.