Do not put an equals and quotes when completing an xml attribute if present #72508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
the
Community
.../CSharpTest/Completion/CompletionProviders/XmlDocumentationCommentCompletionProviderTests.cs
Show resolved
Hide resolved
...tures/VisualBasic/Portable/Completion/CompletionProviders/XmlDocCommentCompletionProvider.vb
Outdated
Show resolved
Hide resolved
src/Features/CSharp/Portable/Completion/CompletionProviders/XmlDocCommentCompletionProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/Completion/Providers/AbstractDocCommentCompletionProvider.cs
Outdated
Show resolved
Hide resolved
.../CSharpTest/Completion/CompletionProviders/XmlDocumentationCommentCompletionProviderTests.cs
Show resolved
Hide resolved
.../CSharpTest/Completion/CompletionProviders/XmlDocumentationCommentCompletionProviderTests.cs
Show resolved
Hide resolved
.../CSharpTest/Completion/CompletionProviders/XmlDocumentationCommentCompletionProviderTests.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Test2/IntelliSense/CSharpCompletionCommandHandlerTests_XmlDoc.vb
Show resolved
Hide resolved
src/EditorFeatures/Test2/IntelliSense/CSharpCompletionCommandHandlerTests_XmlDoc.vb
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Mar 13, 2024
src/EditorFeatures/Test2/IntelliSense/CSharpCompletionCommandHandlerTests_XmlDoc.vb
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Test2/IntelliSense/CSharpCompletionCommandHandlerTests_XmlDoc.vb
Outdated
Show resolved
Hide resolved
|
@CyrusNajmabadi Should be ready for another round of review |
DoctorKrolic
approved these changes
Mar 14, 2024
|
@CyrusNajmabadi This one was ready for another round, should be very close to merge, but the CI is failing for another reason. |
src/Features/Core/Portable/Completion/Providers/AbstractDocCommentCompletionProvider.cs
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Mar 19, 2024
|
Thanks! |
|
@CyrusNajmabadi Seems the CI test is being flaky here (tried to run one that failed locally and it passed) |
|
@CyrusNajmabadi and CI failed again, I don't know why it behaves like this, I try to check the errors, but it doesn't help me much... |
|
it's not you. it's us :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72259
To address this issue, this pr will check to see if there's an Equals token already next to the completion. If there is, we don't place the ="" and only replace the word meant to be completed.
To note about the VB change: it seems the completion on VB works differently and didn't supported this scheme of completion (I tried a unit test and it wasn't even something in the list). So this effectively leaves VB as is.