Always log LSP server processId and increase attach timeout #72531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
Cosifne
reviewed
Mar 13, 2024
| @@ -66,8 +67,7 @@ static async Task RunAsync(ServerConfiguration serverConfiguration, Cancellation | |||
| } | |||
| else | |||
| { | |||
| var timeout = TimeSpan.FromMinutes(1); | |||
| logger.LogCritical($"Server started with process ID {Environment.ProcessId}"); | |||
| var timeout = TimeSpan.FromMinutes(2); | |||
There was a problem hiding this comment.
How to attach debugger on a non-win platform?🤔 Use C# extenstions to debug itself?
There was a problem hiding this comment.
Yup - I do it often on my mac. There's an attach to process command to attach to any dotnet core process
Cosifne
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The processId is useful outside of debugging scenarios (for example when requesting more process information in bug reports). Adjust logging to always report it.
Additionally, increases the timeout waiting for a debugger on non-windows platforms - it can take more than a minute at times to attach.