Fix LspFileChangeWatcher case sensitivity #72555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ryzngard
commented
Mar 15, 2024
| @@ -64,7 +65,8 @@ private class FileChangeContext : IFileChangeContext | |||
| /// The list of file paths we're watching manually that were outside the directories being watched. The count in this case counts | |||
| /// the number of | |||
| /// </summary> | |||
| private readonly Dictionary<string, int> _watchedFiles = new Dictionary<string, int>(StringComparer.Ordinal); | |||
| private readonly Dictionary<string, int> _watchedFiles = new Dictionary<string, int>(_stringComparer); | |||
There was a problem hiding this comment.
I wasn't sure exactly how to add a good test for this, am open to ideas + where it should go
…atcher_casesensitivity
davidwengier
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change events on windows have come in with a lowercase drive letter (locally observed) and would be disregarded for changing. Change the string comparer to be case insensitive on OSes that are not Linux