Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make snippet generation strongly typed. #72892

Merged
merged 29 commits into from
Apr 5, 2024

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Apr 5, 2024

  • Use generics to more clearly articulate the type of syntax various snippets create
  • Simplify code by using language-specific syntax APIs where available (instead of relying on generic ISyntaxFacts helpers)
  • Remove CursorAnnotation since it was functioning as an exact duplicate of FindSnippetAnnotation

This change does not alter the root ISnippetProvider interface or otherwise change the path we would need to take to make these APIs public.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner April 5, 2024 19:28
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 5, 2024
@sharwell sharwell disabled auto-merge April 5, 2024 21:21
@CyrusNajmabadi CyrusNajmabadi merged commit b07ea36 into dotnet:main Apr 5, 2024
25 of 27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 5, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the strongTypeSnippets branch April 5, 2024 22:20
@dibarbet dibarbet modified the milestones: Next, 17.11 P1 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants