Switch to a batching work queue for saving sourcetexts #72926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
sharwell
previously requested changes
Apr 8, 2024
src/Workspaces/Core/Portable/Workspace/Solution/RecoverableTextAndVersion.RecoverableText.cs
Show resolved
Hide resolved
|
Given that it wasn't tracked before, and this clearly is a case where it doesn't need to be tracked today, I'm not sure why this requirement now exists here. If you'd like to add this support here, I won't stop you :-) |
CyrusNajmabadi
dismissed
sharwell’s stale review
The request to have an asynclistener is reasonable, but out of scope. This PR keeps us in the same position wrt that.
|
When we have multiple issues with code X, Y, Z. We should not block a fix/improvement for 'X' just because 'Y' and 'Z' still remain :) |
|
Going to move forward on this. Def ok with future improvements here. |
This was referenced Apr 13, 2024
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.