Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync less project attributes. #72930

Merged
merged 7 commits into from
Apr 9, 2024
Merged

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Apr 8, 2024

Remove 500 single-item sync calls from oop to our host for these attributes. Prior to the change we had:

image

These represent number of calls where we're asking for a single object of that type.

Post the change we have:

image

This means we only make 3 calls from oop to host for this data. One for 314 items, one for 1 item, and one for 270 items.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner April 8, 2024 03:11
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 8, 2024
@CyrusNajmabadi CyrusNajmabadi marked this pull request as draft April 8, 2024 22:31
@CyrusNajmabadi
Copy link
Member Author

Moving to draft. i want to collect current before/after numbers on this before proceeding.

@CyrusNajmabadi CyrusNajmabadi changed the title WIP: Sync less project attributes. Sync less project attributes. Apr 9, 2024
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review April 9, 2024 06:13
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit aadb119 into dotnet:main Apr 9, 2024
27 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the syncLess branch April 9, 2024 16:46
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 9, 2024
@CyrusNajmabadi
Copy link
Member Author

@jasonmalinowski For review when you get back.

@dibarbet dibarbet modified the milestones: Next, 17.11 P1 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants